feat(role): add is_gradient and is_holographic properties #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enegg
suggested changes
Sep 14, 2025
|
Noticed the CI is flagging issues from files I haven’t touched. Looks like some type checks are running across the whole repo. My changes passed the relevant tests and are isolated to |
Enegg
reviewed
Sep 15, 2025
Co-authored-by: Eneg <[email protected]> Signed-off-by: ImChill1n <[email protected]>
Co-authored-by: Eneg <[email protected]> Signed-off-by: ImChill1n <[email protected]>
Co-authored-by: Eneg <[email protected]> Signed-off-by: ImChill1n <[email protected]>
This really fits better. Co-authored-by: Eneg <[email protected]> Signed-off-by: ImChill1n <[email protected]>
Snipy7374
requested changes
Sep 15, 2025
shiftinv
reviewed
Sep 15, 2025
|
I have removed both methods and replaced with enum and style, now distinguishing custom and holographic gradient. |
Snipy7374
requested changes
Sep 15, 2025
|
Reverted Enum changes, I have added 2 methods back. I think current version should be good. |
Snipy7374
requested changes
Sep 15, 2025
Snipy7374
reviewed
Sep 15, 2025
Co-authored-by: Snipy7374 <[email protected]> Signed-off-by: ImChill1n <[email protected]>
Enegg
reviewed
Sep 18, 2025
Comment on lines
+369
to
+371
| def has_custom_gradient(self) -> bool: | ||
| """ | ||
| Whether the role has custom gradient. |
There was a problem hiding this comment.
I don't know about using the word "custom" here, it implies the existence of non-custom gradient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Role.is_gradientandRole.is_holographicproperties based on Discord's role styling behavior.According to the API:
Roles with only primary_color are basic, without styling.
Adding secondary_color makes the role a gradient.
Adding tertiary_color turns it into a holographic style.
These properties check role style and reflect official Discord API behavior.
Checklist
pdm lintpdm pyright